handle cycles between manual chunks #9917
Conversation
🦋 Changeset detectedLatest commit: 711b50f The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hi @nornagon, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
I was running into "Maximum call stack size exceeded" in this
walk()function. I don't have a minimal repro, but I think it was likely caused by circular dependencies either between things in the chunk and things not in the chunk, or things within the chunk itself. This change seems to fix it.Testing Strategy: